typing: Fix typing error of test parametrizations#611
Merged
PierreQuinton merged 2 commits intomainfrom Mar 6, 2026
Merged
Conversation
ValerianRey
added
the
cc: typing
github-actions
bot
changed the title
This was referenced Mar 6, 2026
PierreQuinton
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type of parametrizations was inferred to be list[tuple[UPGrad | IMTLG | ... | TrimmedMean, ...]], and we thus couldn't append the other aggregators to it (NashMTL, CAGrad). This makes the type of parametrizations be list[tuple] so it now works. I couldn't really specify list[tuple[Aggregator, Tensor, Tensor]], because sometimes we also have to add a pytest mark in the tuple, so these really are tuples whose exact type can vary, and thus it's better to not type them very precisely.